Conversation
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 88.06% 87.94% -0.12%
==========================================
Files 5 5
Lines 846 846
==========================================
- Hits 745 744 -1
- Misses 101 102 +1
Continue to review full report at Codecov.
|
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
…a mypy run Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
|
I'm sorry, but I am not an expert of typing and I can not maintain it. I will drop Python 2 support completely in next major version (in 2021 or 2022). I will reconsider this after it. |
|
@methane no worries, I see that someone has created a stubs-only package recently: https://github.com/sbdchd/msgpack-types. So this is not an issue anymore, thus closing. |
3 participants
This PR adds PEP 561 compatibility to
msgpack.I keep the type stubs from this PR for development with
msgpack. The idea is to make them available to everyone by adding them to the distribution. There are no changes to themsgpackcode itself, the stub is completely separated from the real code.If you are against adding type stubs, I'd still be grateful for a review that would improve the stub quality - maybe you have a good advice on how to deal with the remaining
Anytypes.